Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix(issue-417): adding additional asserts to track flaky error #421

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Jun 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #417 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: containeranalysis Issues related to the googleapis/nodejs-containeranalysis API. labels Jun 22, 2022
@pattishin pattishin changed the title Fix/pubsub issue 417 fix(issue-417): adding additional asserts to track flaky error Jun 23, 2022
@pattishin pattishin marked this pull request as ready for review June 23, 2022 00:41
@pattishin pattishin requested review from a team as code owners June 23, 2022 00:41
@averikitsch averikitsch added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@pattishin pattishin merged commit 23cd446 into main Jun 23, 2022
@pattishin pattishin deleted the fix/pubsub-issue-417 branch June 23, 2022 18:36
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 4, 2022
🤖 I have created a release *beep* *boop*
---


## [4.2.0](v4.1.0...v4.2.0) (2022-07-04)


### Features

* support regapic LRO ([1290f13](1290f13))


### Bug Fixes

* **deps:** update dependency @google-cloud/grafeas to v4 ([#420](#420)) ([6e40ebe](6e40ebe))
* **issue-417:** adding additional asserts to track flaky error ([#421](#421)) ([23cd446](23cd446))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this pull request Nov 9, 2022
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-containeranalysis@v4.1.0...v4.2.0) (2022-07-04)


### Features

* support regapic LRO ([1290f13](googleapis/nodejs-containeranalysis@1290f13))


### Bug Fixes

* **deps:** update dependency @google-cloud/grafeas to v4 ([#420](googleapis/nodejs-containeranalysis#420)) ([6e40ebe](googleapis/nodejs-containeranalysis@6e40ebe))
* **issue-417:** adding additional asserts to track flaky error ([#421](googleapis/nodejs-containeranalysis#421)) ([23cd446](googleapis/nodejs-containeranalysis@23cd446))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-containeranalysis@v4.1.0...v4.2.0) (2022-07-04)


### Features

* support regapic LRO ([1290f13](googleapis/nodejs-containeranalysis@1290f13))


### Bug Fixes

* **deps:** update dependency @google-cloud/grafeas to v4 ([#420](googleapis/nodejs-containeranalysis#420)) ([6e40ebe](googleapis/nodejs-containeranalysis@6e40ebe))
* **issue-417:** adding additional asserts to track flaky error ([#421](googleapis/nodejs-containeranalysis#421)) ([23cd446](googleapis/nodejs-containeranalysis@23cd446))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: containeranalysis Issues related to the googleapis/nodejs-containeranalysis API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub occurrences from pubsub subscription: should delete the pubsub subscription failed
2 participants